Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove qpud #91

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Remove qpud #91

merged 2 commits into from
Apr 21, 2023

Conversation

amccaskey
Copy link
Collaborator

We no longer use this tool. Time to remove it.

bettinaheim
bettinaheim reviewed Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am remembering correctly, the CUDA Quantum runtime dependencies libcurl4-openssl-dev and libssl-dev may only have been needed for the QPUD client. Could you please check if you can remove them from the cudaq.Dockerfile?

.gitmodules Show resolved Hide resolved
@amccaskey
Copy link
Collaborator Author

Those packages are still required for the RestClient.

schweitzpgi
schweitzpgi approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waving goodbye...

@amccaskey
Remove qpud
3b89950 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
remove rpclib from notice
85276e6 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey amccaskey enabled auto-merge (squash) April 20, 2023 20:01
@amccaskey amccaskey merged commit a48f153 into NVIDIA:main Apr 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2023
@amccaskey amccaskey deleted the removeQpud branch May 26, 2023 16:43
@bettinaheim bettinaheim added the breaking change Change breaks backwards compatibility label Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bettinaheim bettinaheim bettinaheim left review comments

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees
No one assigned
Labels
breaking change Change breaks backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amccaskey @schweitzpgi @bettinaheim